pelican icon indicating copy to clipboard operation
pelican copied to clipboard

Upgrade GitLab Pages support to Pelican 4.0.1

Open davidag opened this issue 5 years ago • 27 comments

GitLab has a Pages feature, which is similar to GitHub Pages. I've detected a couple of problems using Pelican on GitLab Pages:

I've submitted a PR for the first issue: https://gitlab.com/pages/pelican/merge_requests/9

I'm looking into the second one.

davidag avatar May 16 '19 14:05 davidag

The merge request was merged, so the first issue is fixed :tada:

With respect to the second issue, according to the repository owner, he will submit it to be included as a built-in template in GitLab.

davidag avatar May 29 '19 14:05 davidag

An issue has been created in the project-templates repo to handle the addition of Pelican to GitLab Pages. Let's hope this keeps the momentum :)

davidag avatar Jun 04 '19 15:06 davidag

Thanks for the updates on this endeavor, David. Would you like to update the template(s) from Pelican 4.0.1 to the recently-released version 4.1?

justinmayer avatar Jul 23 '19 11:07 justinmayer

Opened MR with updated template as generated by Pelican 4.1.0 customized for GitLab Pages

When this is merged, I'll try to push again for Pelican to be included as a built-in template :crossed_fingers:

davidag avatar Aug 09 '19 19:08 davidag

Many thanks for the update, David. Following is a minor update of my own… 😉

Thanks to my new project AutoPub, Pelican 4.1.1 was automatically released a few days ago. We try to use semantic versioning, and befitting the patch version designation, the changes in 4.1.1 are minor, so I don't think there's any need to rush out to submit another MR to GitLab. But in case you hadn't heard, I at least wanted to let you know that a new version has been released. And now that Pelican releases are automated, the release cadence should be noticeably more frequent.

To that end… After taking a belated look at your GitLab MR (and I must apologize for reviewing it after it was merged and not before), I noticed two things that might be adjusted to account for the new turbo-charged release cadence:

  1. Instead of pinning via pelican == 4.1.0 in the requirements file, you might consider changing the version specifier to instead utilize the compatible release version clause: pelican ~= 4.1.0. That should be equivalent to >= 4.1.0, == 4.1.* and should obviate the need to submit an additional MR every time AutoPub publishes a new Pelican patch release.

  2. Similarly, when linking to the Pelican docs, you might consider linking to the stable docs instead of the version 4.1.0 docs. That way, the link to the documentation won't need to be updated after every tiny patch release.

What do you think?

justinmayer avatar Aug 29 '19 15:08 justinmayer

Thanks for the feedback, Justin!

About the version specifier, my intention when adding it was to avoid incompatibilities between Pelican core and the skeleton files. This leads to the problems that you pointed out.

The thing is that without a criterion of when major, minor and patch version numbers will change, it's difficult to be sure that a new Pelican core won't be incompatible with previously generated skeleton files. Sorry if the criterion exists, but I couldn't find it easily, maybe it's a convention, maybe it's not written yet.

What I try to say is that I would prefer to use pelican ~= 4.0 making MRs even less necessary :relaxed: but it doesn't seem like a wise move right now.

Beyond the versioning criteria, it seems that changes in the generated skeleton files should be available in the example GitLab repository as quickly as possible. There's no clear way to know when this kind of changes happens. Maybe a special keyword in the changelog could help?

As for the documentation, it would be great to have a version 4.1 (or even 4) link that would redirect to the latest 4.1.x (or 4.x) docs, but I guess that's not easily doable.

https://docs.getpelican.com/en/4.1/install.html -> https://docs.getpelican.com/en/4.1.1/install.html

Summing up, your suggestions look very reasonable and I'll be happy to push them. Just wanted to let you know how the situation could be improved even more, in my opinon :relaxed:

PD: Congrats on the AutoPub project, I didn't know it was yours! I can understand why you created it :tada:

PD2: Merge Request ~~in progress~~ merged :tada:

davidag avatar Aug 30 '19 09:08 davidag

:wave: I can help with getting Pelican as a Pages template :) Is there a logo in SVG?

axilleas avatar Aug 30 '19 11:08 axilleas

@axilleas That's great!! I'm not sure if there's any Pelican logo (though it seems like a nice idea :) Maybe @justinmayer can let us know.

davidag avatar Sep 02 '19 09:09 davidag

@axilleas I think this is the logo: https://twitter.com/getpelican/photo but I couldn't find it in Pelican's github repositories.

davidag avatar Sep 02 '19 11:09 davidag

@axilleas: Many thanks for reaching out. I'm working on putting up an SVG version of the logo and will post an update here as soon as I can.

justinmayer avatar Sep 02 '19 14:09 justinmayer

SVG version of logo posted: https://gitlab.com/gitlab-org/project-templates/contributing/issues/1#note_218321551

justinmayer avatar Sep 17 '19 15:09 justinmayer

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your participation and understanding.

stale[bot] avatar Nov 16 '19 15:11 stale[bot]

:wave: I started working on adding Pelican in https://gitlab.com/gitlab-org/gitlab/merge_requests/16934, but I hadn't found the time since to continue... I'm hoping to pick it up again soon.

axilleas avatar Nov 17 '19 07:11 axilleas

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your participation and understanding.

stale[bot] avatar Jan 16 '20 09:01 stale[bot]

Hi @axilleas. Have you been able to make any progress on this endeavor?

justinmayer avatar Jan 24 '20 05:01 justinmayer

Hi @axilleas. Have you been able to make any progress on this endeavor?

@justinmayer unfortunately not yet :/

axilleas avatar Feb 04 '20 07:02 axilleas

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your participation and understanding.

stale[bot] avatar Apr 04 '20 09:04 stale[bot]

@davidag: I'm going to assign this issue to you in order to prevent it from being marked as stale. As a side note, I'll try to get a new Pelican release out soon so it can hopefully be utilized if and when it's added to GitLab Pages.

justinmayer avatar Apr 06 '20 08:04 justinmayer

@justinmayer thanks!

axilleas avatar Apr 06 '20 19:04 axilleas

@justinmayer: Perfect, I'll update the GitLab template repository when the version is released.

davidag avatar Apr 07 '20 17:04 davidag

Hi, thanks for all the work. I still do not see the Pelican template in GitLab 13, "create from template" option.

kakila avatar Jun 13 '20 22:06 kakila

Hi, thanks for all the work. I still do not see the Pelican template in GitLab 13, "create from template" option.

Yeah, I still haven't got any time to work on it :(

axilleas avatar Jun 14 '20 10:06 axilleas

@axilleas: Now that Pelican 4.5 has been released, I thought I'd follow up regarding this issue. Do you think you might be able to carve out a bit of time to add Pelican to GitLab Pages?

justinmayer avatar Oct 12 '20 12:10 justinmayer

@justinmayer : @axilleas upgraded to Pelican 4.7 4 months ago: https://gitlab.com/pages/pelican/.

I guess you can close this issue.

mat-m avatar May 08 '22 00:05 mat-m

@justinmayer I'm happy to report that I managed to get the Pelican template merged into GitLab 😄 This will be part of GitLab 15.1 released on June 22nd where you'll be able to create a Pelican site by using the built-in templates 🙂

axilleas avatar May 31 '22 09:05 axilleas

@davidag you can close this issue now 🙂

axilleas avatar Jun 02 '22 13:06 axilleas

Many thanks for getting the Pelican template into GitLab, @axilleas! 🎉

justinmayer avatar Aug 02 '23 09:08 justinmayer

No. This should not be considered as complete. See #3263

Ryder17z avatar Dec 03 '23 08:12 Ryder17z