pelican-plugins icon indicating copy to clipboard operation
pelican-plugins copied to clipboard

[Migration] filetime_from_hg

Open vishwin opened this issue 4 years ago • 4 comments

I'd like to migrate this plugin out of this monorepo into the pelican-plugins org, to at the very least serve as a place for continued development and maintenance. I've already created a repo using the CookieCutter, with the history from here git-filter-branch(1)ed out plus a bugfix commit from me, ready to transfer into the org.

cc: @douardda

vishwin avatar Dec 28 '20 13:12 vishwin

thanks, looks fine to me, do you need any help from me?

douardda avatar Dec 30 '20 15:12 douardda

@douardda I guess you were CCed because @vishwin identified you as the original author of the plugin.

Looking around I can't unseen the existence of filetime_from_git plugin. @vishwin : what's the effort to merge the two?

kdeldycke avatar Jan 04 '21 20:01 kdeldycke

My last comment, now deleted, misspoke as I read that as filetime_from_hg. filetime_from_git is a completely different implementation. This plugin is as simple/short as it is because we use python-hglib from the official Mercurial project, and merging with the other plugin would introduce unnecessary complexities, not least of juggling two different library imports. I also don't personally use the other plugin. Thus, there is no effort to merge the two.

My CC was more of asking the original author for some tacit approval.

vishwin avatar Jan 05 '21 02:01 vishwin

I agree that merging both the plugins would make things unnecessarily complex, even if they share some code (obviously, since filetime_from_hg has been written from filetime_from_git, as I mentioned in the README file IIRC) .

douardda avatar Jan 05 '21 08:01 douardda