heroku-buildpack-pelican
heroku-buildpack-pelican copied to clipboard
getpelican
Disabling the cache breaks push to Dokku
The last patch to disable the cache causes push to Dokku to fail...
remote: rm: cannot remove `/cache': Device or resource busy
Appreciate that this may not work on Heroku, but raising the bug to ensure any Dokku users either revert the patch in question or use my fork (where I've fixed this) until the cache issue is resolved.
@dave-tucker I don't see how this has anything to do with Dokku, this is a buildpack for Heroku. Hence the repository name. This is designed to work for Heroku.
@kylef Dokku uses Heroku Buildpacks. If you feel that strongly about it, I'll maintain a permanent fork of this repo for Dokku and not bother pushing back upstream.
@dave-tucker Hmm, I didn't know Dokku is heroku compatible thing. I'd be willing to accept a pull-request adding support for Dokku if you would like to make one.
The cache was disabled because it's not working correctly and actually causing the nginx install to break every time you push to Heroku with an existing cache. (I'd love to actually make the cache work but I haven't found the time to fix it).
@kylef the changes required were pushed in https://github.com/getpelican/heroku-buildpack-pelican/pull/4 (along with support for PCRE) which removed the "rm -rf $CACHE_DIR".
Adding this back has caused a regression from my standpoint (as a Dokku user) hence raising the bug.
This repo's purpose is to serve Heroku users first and foremost but I think it's still worthwhile leaving this bug open until the cache issue is fixed as an FYI for any users of Dokku... if I can find some spare cycles I'll see if I can look in to the issue further... it may also help to have an issue raised for that too.
@dave-tucker I think I'll add a environmental variable to enable the cache, something like PELICAN_USE_BUILD_CACHE or something which you can set to true to enable (disabled by default).
When it's working, we will just change the default to true and it will allow people to opt-out.
@Chris2048 and @kylef having myself experienced issues when deploying to Dokku, I believe I've found a solution as described here: #15.
What do you guys think?
