heroku-buildpack-pelican icon indicating copy to clipboard operation
heroku-buildpack-pelican copied to clipboard

Env var behaviour for cache removal.

Open born2discover opened this issue 7 years ago • 4 comments

This fixes #6 and introduces a new environment variable "PLATFORM" which when defined and set to "DOKKU" would force the buildback not to perform the cache deletion command. Otherwise if the env variable is not set, or set to "HEROKU" then that command will be performed.

For Dokku users it means adding an additional export statement in their .env file.

Example contents of .env file:

# Can be either DOKKU or any other string different from HEROKU.
export PLATFORM="DOKKU"
export BUILDPACK_URL=https://github.com/born2discover/heroku-buildpack-pelican

born2discover avatar Jul 19 '17 11:07 born2discover

+1 for this PR. Working very well on my dokku+pelican apps,

Thanks for the work,

julbrs avatar Nov 02 '17 12:11 julbrs

Any thoughts on this PR, @kylef?

justinmayer avatar Nov 02 '17 13:11 justinmayer

Looks like this never got merged :( and @born2discover removed their fork

chadselph avatar Jul 11 '20 19:07 chadselph

Looks like this never got merged :( and @born2discover removed their fork

@chadselph : As I am not using this build-pack myself anymore I indeed have recently removed my fork. However the changes I proposed are still available on Github, just check the "Files changed" tab, so the proposed feature can still be implemented.

born2discover avatar Jul 11 '20 20:07 born2discover