skunkworks-crow icon indicating copy to clipboard operation
skunkworks-crow copied to clipboard

Published 20 hours ago • verified publisher icon getodk

Adding back button in settings activity and confirmation dialog in main activity

Open htg2704 opened this issue 4 years ago • 3 comments

Closes #372 Closes #369

What has been done to verify that this works as intended?

Verified on a physical device.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Better user experience.

Before submitting this PR, please make sure you have:

  • [ ] run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • [ ] verified that any code or assets from external sources are properly credited in comments and/or in the about file.

htg2704 avatar Mar 13 '20 17:03 htg2704

@htg2704 are you still working on this?

ajay-prabhakar avatar Apr 11 '20 16:04 ajay-prabhakar

@Chromicle I made a commit 20 days back. I will see why it's not passing the test because according to me I made all necessary changes.

htg2704 avatar Apr 11 '20 16:04 htg2704

yeah, but you build is failing due to pmd check, run ./gradlew checkcode locally you will get detailed information on how to solve that error and please solve the conflicts

ajay-prabhakar avatar Apr 11 '20 16:04 ajay-prabhakar