skunkworks-crow icon indicating copy to clipboard operation
skunkworks-crow copied to clipboard

Fix #358

Open maharishi-01 opened this issue 5 years ago • 6 comments

Closes #358

What has been done to verify that this works as intended?

Test on android 9. Go to Main Activity Click Receive(if you are not in Bluetooth mode switch to Bluetooth mode)

Why is this the best possible solution? Were any other approaches considered?

Looking great.

How does this change affect users? Describe intentional changes to behaviour and behaviour that could have accidentally been affected by code changes. In other words, what are the regression risks?

good User experience.

Before submitting this PR, please make sure you have:

  • [x] run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • [x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.

maharishi-01 avatar Feb 20 '20 21:02 maharishi-01

i don't know why it show error

maharishi-01 avatar Feb 20 '20 21:02 maharishi-01

please help me

maharishi-01 avatar Feb 20 '20 21:02 maharishi-01

Hello, @maharishi1 as you are new to the community I am just saying some things we should fallow and it is really helpful if you read contributing guidelines

  • if any new feature we have to discuss with mentors(applies for this issue) do not work before that
  • Don't put PR's before assigning to you so, no one has any confusions
  • Before putting PR run ./gradlew checkcode locally in the terminal if you have any error you can detailed info about that

ajay-prabhakar avatar Feb 22 '20 08:02 ajay-prabhakar

Thanks @Chromicle for such clear guide and suggestions. Another thing is @maharishi1 , if you add a brief title to this PR, it will be better and more friendly to other reviewers.

huangyz0918 avatar Feb 25 '20 01:02 huangyz0918

@maharishi1 are you still working on this if yes, fix the build issue

ajay-prabhakar avatar Mar 03 '20 15:03 ajay-prabhakar

Yes I am trying.....but the one of the ci/circlei is failed.....so I am still stuck in it

maharishi-01 avatar Mar 03 '20 16:03 maharishi-01