skunkworks-crow
skunkworks-crow copied to clipboard
fix: list only smart phones for scanning bluetooth devices
Closes #346
What has been done to verify that this works as intended?
- Checked whether it is listing the smartphones are only or not
- Checked whether any new warnings are produced by adding this code
- Checked any tests are failing
- Checked by changing the orientation of the devices
- Checked by transferring Forms
Why is this the best possible solution? Were any other approaches considered?
With the help of BluetoothClass checked if the device is the smartphone then added into Bluetooth device list with help of if the condition
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
By adding this fix user can directly select the device to transfer forms
GIF
list of devices before this feature

list of devices after this feature

Before submitting this PR, please make sure you have:
- [x] run
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes - [x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.
@lakshyagupta21 can you please review my PR's if you are free I made PR's for all the issues I claimed
have you test for the android tablets? Is the change disable the tablets?
@huangyz0918 My friend checked and he said it is showing as expected
@lakshyagupta21 I added the check for NPE, can you please review now