skunkworks-crow icon indicating copy to clipboard operation
skunkworks-crow copied to clipboard

Disable button instead of showing toast for null validation

Open ajay-prabhakar opened this issue 5 years ago • 4 comments

Software and hardware versions

Android 9, Samsung J8

Problem description

Currently, In settings activity we are showing the toast that Name should not be empty if the length of the string equals to 0 in every EditTextPreference Instead of showing toast, disable the positive button so, user can directly know that he did not have to enter the null value in EditText or else he/she have to click once again on preference and have to edit

Steps to reproduce the problem

Go to Settings activity Open any editText and give a null value observe the toast

Expected behavior

Instead of showing toast disable the positive button for editTextPreference for null validation

GIF

ezgif com-video-to-gif (1)

@opendatakit-bot claim

ajay-prabhakar avatar Jan 30 '20 12:01 ajay-prabhakar

@Chromicle It would always be helpful if you attach some screenshots or gifs whenever you raise an UI change request.

lakshyagupta21 avatar Jan 30 '20 12:01 lakshyagupta21

@Chromicle And I would suggest to claim issues once you're done with other issues.

lakshyagupta21 avatar Jan 30 '20 12:01 lakshyagupta21

Yeah, I updated in PR template and I have one doubt how many issues can we claim as I don't know that I claimed this issue and I will make PR's for whatever the issue I claimed by today

ajay-prabhakar avatar Jan 30 '20 15:01 ajay-prabhakar

Hello @Chromicle, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

getodk-bot avatar Feb 14 '20 18:02 getodk-bot