skunkworks-crow icon indicating copy to clipboard operation
skunkworks-crow copied to clipboard

Fixed Crash On Searching In Sent/Reviewed Fragments

Open SaumiaSinghal opened this issue 5 years ago • 1 comments

Closes #224

What has been done to verify that this works as intended?

I tested it on Android 9.0.

Issue#224

Why is this the best possible solution? Were any other approaches considered?

I found that there was an error in SQL query that extracts the forms from database, and corrected it.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No regression risks

Before submitting this PR, please make sure you have:

  • [x] run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • [x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.

SaumiaSinghal avatar Jan 12 '20 17:01 SaumiaSinghal

@lakshyagupta21 You can have a quick look if you have time. Thanks

PS. I don't have permissions to merge PR or request for somebody's review.

huangyz0918 avatar Jan 22 '20 11:01 huangyz0918