skunkworks-crow icon indicating copy to clipboard operation
skunkworks-crow copied to clipboard

fix: using app without odk collect installed

Open naman653 opened this issue 5 years ago • 1 comments

Closes #337

What has been done to verify that this works as intended?

Verified by testing on Vivo Z1 Pro running on Android v9.x.x

Why is this the best possible solution? Were any other approaches considered?

NA

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It restricts the user from using the app without installing ODK collect app.

Before submitting this PR, please make sure you have:

  • [x] run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • [x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.

naman653 avatar Jan 11 '20 11:01 naman653

Looks good to me, thanks for your contribution @naman653 , let @lakshyagupta21 to see if the code is ok to merge.

huangyz0918 avatar Jan 16 '20 10:01 huangyz0918