skunkworks-crow icon indicating copy to clipboard operation
skunkworks-crow copied to clipboard

Removed redundant tab

Open KomoderHell opened this issue 5 years ago • 3 comments

Closes #179

How does this change affect users?

previously received and reviewed tabs showed similar sets of data, the received tab was used to approve forms whereas reviewed tab was used to send reviewed forms. In this work i merged the functionalities of both the tabs into one by making a few changes and removed the redundant reviewed tab, the user can now approve forms as well as send approved forms from received tab.

Before submitting this PR, please make sure you have:

  • [ ] run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • [x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.

KomoderHell avatar Jan 07 '20 11:01 KomoderHell

@lakshyagupta21 this PR is failing the first test, and i am unable to figure out the problem. will you please look into the matter and review this PR

KomoderHell avatar Jan 08 '20 14:01 KomoderHell

@sujaykaushik008 Did you run ./gradlew checkCode before pushing the commit, it looks like pmd check is failing you can run this in your terminal and look at the pmd report generated at the end.

lakshyagupta21 avatar Jan 08 '20 16:01 lakshyagupta21

@lakshyagupta21 sir, I did as you said the report says that a number of my files are deprecated and will be removed in PMD 7.0.0 . I have not done any changes in the files mentioned in this report

KomoderHell avatar Jan 12 '20 09:01 KomoderHell