skunkworks-crow icon indicating copy to clipboard operation
skunkworks-crow copied to clipboard

fix: Fixed crash while sending forms through hotspot

Open ajay-prabhakar opened this issue 5 years ago • 2 comments
trafficstars

Closes #323

What has been done to verify that this works as intended?

Checked whether the crash is happening or not while sending the forms for the second time through hotspot transformation

Why is this the best possible solution? Were any other approaches considered?

As we are making local hotspot request once again so, checked whether the hotspot is initiated before we request for hotspot

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Crash is not the good behavior of the ideal app so, by fixing that user can directly send the forms for a second time without restarting the app

Before submitting this PR, please make sure you have:

  • [x] run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • [x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.

ajay-prabhakar avatar Nov 30 '19 16:11 ajay-prabhakar

@lakshyagupta21 can you please review and let me know if any changed required 😄

ajay-prabhakar avatar Nov 30 '19 16:11 ajay-prabhakar

I think you can merge this @lakshyagupta21, I tested everything and working fine

ajay-prabhakar avatar Dec 26 '19 18:12 ajay-prabhakar