skunkworks-crow
skunkworks-crow copied to clipboard
getodk
Improvements in bottom bar layout
Closes #174
What has been done to verify that this 4works as intended?
Tested in Android Studio and my phone(Samsung j8), it looks good as I expected
GIF
Why is this the best possible solution
Made 2 drawable resource files so 2 buttons look different and applied the background to the buttons also. and added the same layout to fill forms and blank forms and main activity also
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
As by updating the UI so it holds good for user experience and so the app looks like beautiful
Before submitting this PR, please make sure you have:
- [x] run
./gradlew pmd checkstyle lint findbugsand confirmed all checks still pass OR confirm CircleCI build passes - [x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.
@shobhitagarwal1612 @lakshyagupta21 I made the suggestions given by you can you have a look now
@lakshyagupta21 as you suggested that background color white is looking odd I tried some of the other colors similar to the primary color of the app but it does not looks good
The disabled buttons look just like enabled. Please fix
Initially, I made in the color of gray but @lakshyagupta21 suggested me to make it into app primary color so I made like that, can you suggest me color to make it
The text color should be grayed out similar to the original button's implementation.
@shobhitagarwal1612 @lakshyagupta21 I made the changes suggested by you and I updated how it looks like in PR template can you please review it
@lakshyagupta21 @shobhitagarwal1612 I have done the changes and I added the styles instead of adding same to code to everywhere and I did testing twice and it is working perfectly as accepted can you please review now
@lakshyagupta21 @huangyz0918 can you please review this PR as there are a lot of file changes every time new PR merges I have to solve the conflict