skunkworks-crow icon indicating copy to clipboard operation
skunkworks-crow copied to clipboard

Remove redundant tab

Open shobhitagarwal1612 opened this issue 5 years ago • 15 comments

There are 4 tabs displayed on clicking on any form from the main screen

  • Statistics
  • Received
  • Sent
  • Reviewed

Both received and reviewed contains the same list of instances. The items of received tab are non-clickable making it useless since the same list is also available in reviewed. The items in the reviewed tab are clickable and the instances can be reviewed and marked as approved / rejected. This must be improved. I propose that those two can be combined together into one

@lakshyagupta21 Please provide your input. Others are also welcome to join to discussion

shobhitagarwal1612 avatar Mar 06 '19 04:03 shobhitagarwal1612

Maybe we can combine the two by renaming the Reviewed Tab to Received and remove the old Received Tab. And then, in Received tab we can mark the instances as approved/rejected using an icon/label.

iadeelzafar avatar Mar 06 '19 05:03 iadeelzafar

We can apply the features of the reviewed tab to the received tab or vice-versa. Instead of removing the redundant tab we can use it to display some other productive information like time, date, transfer-info etc. or a chart,graph to display that data.

iamvasuh avatar Mar 06 '19 12:03 iamvasuh

Proposed solution:

  • Statistics
  • Sent
  • Received

@lakshyagupta21 @iadeelzafar @iamvasuh Thoughts?

shobhitagarwal1612 avatar Mar 09 '19 18:03 shobhitagarwal1612

The above-proposed solution looks great and we should make sure that the "Received" tab has all features of the "Reviewed" tab.

iamvasuh avatar Mar 10 '19 06:03 iamvasuh

Is anyone working on this?

rohap97 avatar Mar 23 '19 11:03 rohap97

No, it is still unclaimed

shobhitagarwal1612 avatar Mar 24 '19 05:03 shobhitagarwal1612

@shobhitagarwal1612 i would like to work on this

devanshi7799 avatar Dec 30 '19 13:12 devanshi7799

@devanshi7799 Sure go ahead and you can start with any open issues which are unclaimed. But do check if any issues have any open PRs or not.

lakshyagupta21 avatar Dec 30 '19 17:12 lakshyagupta21

Is someone working on this? if not I would like to work on it

KomoderHell avatar Jan 05 '20 09:01 KomoderHell

Hello @sujaykaushik008 welcome to ODK, and thanks for showing intrest on solving issue @devanshi7799 asked to work on this 6 days ago but she did not claimed it Wait for her reply if she did not working you can work on this

ajay-prabhakar avatar Jan 05 '20 10:01 ajay-prabhakar

@sujaykaushik008 As i am currently working on some other issues, i have not yet started woking on this one. You can claim and work on this :)

devanshi7799 avatar Jan 05 '20 10:01 devanshi7799

ok so to be clear the task is to remove the reviewed tab and change the received tab so that it has functionalities of both reviewed and received tabs. @opendatakit-bot claim

KomoderHell avatar Jan 05 '20 12:01 KomoderHell

Welcome to Open Data Kit, @sujaykaushik008! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/skunkworks-crow/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

getodk-bot avatar Jan 05 '20 12:01 getodk-bot

Hello @sujaykaushik008, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

getodk-bot avatar Jan 22 '20 09:01 getodk-bot

Hi @sujaykaushik008, I just noticed the checkCode bugs in your PR#333 for this issue. May I work on that to make it work through the integration part?

qhb1001 avatar Mar 17 '20 23:03 qhb1001