collect
collect copied to clipboard
getodk
Size of Icons on buttons does not scale with text font size
ODK Collect version
the master version 2f8d4177298df1091fd9f84eb849023a4d3789d5
Android version
10, 11, 14
Device used
Samsung Galaxy M12, Redmi 9T, Pixel 7A
Problem description
Size of Icons on buttons does not scale with text font size. Issue doesn’t occur in the store version 2024.1.2.
Steps to reproduce the problem
- Go to Start new form
- Go to All Widgets form
- Go to Video Widget
- Open Project settings - User interface - Text font size
- Change font size
- Go back to Video Widget
- Repeat steps 4-6 for all text fonts size
Expected behavior
Size of Icons on buttons should scale with text font size
Font size comparsion
| Extra Small | Small | Medium | Large | Extra Large |
|---|---|---|---|---|
@alyblenkin do you think they should here? Going under the hood a little, icons generally use dp defined sizing rather than sp (the latter of which is dynamic based on the UI text size) so I generally don't think about icons scaling with the UI font size. The text size for form questions is an in-app setting however, so we might have a different approach here.
@alyblenkin do you think they should here?
It makes sense that we wouldn't want icons scaling with the UI font size, and I believe we talked about that when we increased the icon size the other week. However, it does look a bit strange when you change the text size settings and they don't scale uniformly.
It seems more drastic here than on my device, but it's very noticeable for icons such as the video, range picker, and geo icons compared to the others. Overall, it's not great, given that some people might rely on the icon more than the text in some cases. We may want to consider a different approach here if that's possible.
We may want to consider a different approach here if that's possible.
Your call! I could see it either way.
@seadowg We discussed this one straight after the call. I'm not sure how many people change their app settings vs their device settings because if you change your device settings, everything scales nicely. @grzesiek2010 said he was going to have a look into this as well.