collect icon indicating copy to clipboard operation
collect copied to clipboard

Update the way valid/invalid drafts are displayed on a map

Open grzesiek2010 opened this issue 11 months ago • 2 comments

Closes #5787

Why is this the best possible solution? Were any other approaches considered?

I don't think there is anything particular we should discuss here. I have expanded the existing functionality following already existing patterns.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The changes I have added are described in the issue. When it comes to testing please test displaying forms on a map and also select one from map. This is the main source of risk.

Do we need any specific form for testing your changes? If so, please attach one.

Any form with geo questions that allows displaying forms on a map.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • [x] added or modified tests for any new or changed behavior
  • [x] run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • [x] added a comment above any new strings describing it for translators
  • [x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • [x] verified that any new UI elements use theme colors. UI Components Style guidelines

grzesiek2010 avatar Mar 05 '24 10:03 grzesiek2010

@grzesiek2010 - It's looking good! Could we add a bit more spacing between the pill and headline label, similar to what we have in the drafts list? Screenshot 2024-03-05 at 2 51 57 PM

alyblenkin avatar Mar 05 '24 22:03 alyblenkin

Could we add a bit more spacing between the pill and headline label, similar to what we have in the drafts list?

Done.

grzesiek2010 avatar Mar 06 '24 09:03 grzesiek2010

@alyblenkin I'm not sure if the change in width in horizontal view is expected? horizontallll

dbemke avatar Mar 29 '24 14:03 dbemke

@alyblenkin I'm not sure if the change in width in horizontal view is expected?

I think the bottom sheet should still be full-width. Based on the material guide , it looks like they can be flexible, but I think to prevent the awkward spacing with the map icons it should be full width.

alyblenkin avatar Apr 02 '24 16:04 alyblenkin

Tested with Success!

Verified on device with Android: 10, 12, 13

Verified cases:

  • Work towards #5787
  • Regression check on the Geospatial Question Types;
  • Additional checks on forms with Select One from map;
  • Viewing submission on maps;
  • Offline Layers;
  • Collecting Location in background;
  • Screen rotation, minimize app, using backward button,

srujner avatar Apr 04 '24 13:04 srujner

Tested with Success!

Verified on device with Android: 11

WKobus avatar Apr 04 '24 13:04 WKobus