collect
collect copied to clipboard
Removed the regression test package
Why is this the best possible solution? Were any other approaches considered?
The regression package was a set of tests written by the QA team. It's been a while since the QA team added something there and we have decided that it will no longer be their responsibility. I have reviewed the tests:
- removing duplicated tests
- reworking/moving test that we (developers) might still need
- removing tests that didn't make much sense from my (dev) perspective or were difficult to understand.
The test cases that were covered by the tests I've removed are still performed manually by the QA team during regression testing I belive so it shouldn't be dangerous.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
- [x] added or modified tests for any new or changed behavior
- [x] run
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still pass - [x] added a comment above any new strings describing it for translators
- [x] verified that any code or assets from external sources are properly credited in comments and/or in the about file.
- [x] verified that any new UI elements use theme colors. UI Components Style guidelines