collect
collect copied to clipboard
Import offline layers into projects and globally
Draft PR that Closes #5845
Why is this the best possible solution? Were any other approaches considered?
This issue has been primarily discussed on https://forum.getodk.org/t/provide-a-way-to-get-mbtiles-to-collect-without-having-to-connect-to-a-computer/42206 and
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Users
Do we need any specific form for testing your changes? If so, please attach one.
Tested using "Select a point" question on "Collect v2022.2 Select one from map" question
Does this change require updates to documentation? If so, please file an issue here and include the link below.
This is a draft PR; I will create an issue once the PR is more robust.
Before submitting this PR, please make sure you have:
- [ ] added or modified tests for any new or changed behavior
- [ ] run
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still pass - [ ] added a comment above any new strings describing it for translators
- [ ] verified that any code or assets from external sources are properly credited in comments and/or in the about file.
- [ ] verified that any new UI elements use theme colors. UI Components Style guidelines
Here's a demo of
- MBtile import into the project
- Mbtile delete from project
- Mbtile added on the map
https://github.com/getodk/collect/assets/11831955/fc089a06-08cc-45b7-bfed-d005f77cc003
Thanks @konishon! I'm still catching up on this after my Christmas break so might be a little more delayed than usual getting to this.
@konishon it looks like the checks are failing. Are you able to fix those before we dive into a review?
Looking at the failure logs, it looks like the PMD checks are failing. This can be run locally with ./gradlew pmd
. You can also run all style checks with ./gradlew checkCode
.
Closing this as it's been inactive for a while. Someone else will likely take on #5845.