collect icon indicating copy to clipboard operation
collect copied to clipboard

Published 20 hours ago • verified publisher icon getodk

In OSM clicking View or Change Geotrace/Geoshape, after having saved a few points with manual location recording, zooms to a wrong place

Open dbemke opened this issue 2 years ago • 4 comments

Software and hardware versions

Android all

Problem description

In OSM clicking View or Change Geotrace/Geoshape after having saved a few points in manual location recording way, zooms to some continent view ( not to location).

Steps to reproduce the problem

  1. Choose OpenStreetMap in settings as a source of maps.
  2. Open All widgets form.
  3. Go to Geoshape/Geotrace widget.
  4. Click on adding location button and choose manual location recording.
  5. Click start.
  6. Add a few points.
  7. Click save.
  8. Click View or Change Geotrace/Geoshape.

Expected behavior

Map is zoomed to the place where the points were added.

dbemke avatar Jul 13 '22 11:07 dbemke

Not able to reproduce this. It also zooms to the recorded points for me. Do the points have to be far from current location or something?

seadowg avatar Jul 21 '22 12:07 seadowg

@seadowg I recorded a video to show the zoom( video with fake gps but work the same without it) . I was thinking that after going back to map it should zoom in.

https://user-images.githubusercontent.com/56479916/180249122-f4000d21-0e9d-4fd7-833b-ea9a5c5a6eca.mp4

dbemke avatar Jul 21 '22 15:07 dbemke

@dbemke does this happen on multiple devices?

seadowg avatar Jul 22 '22 09:07 seadowg

@seadowg Now I've checked again Android 11, 8.1 Collect v 2022.3 Beta 2 and on Android 11 Collect v2022.2.3 and in all cases result is like the one this video.

dbemke avatar Jul 22 '22 10:07 dbemke

@srujner are you able to reproduce this as well?

seadowg avatar Oct 05 '22 14:10 seadowg

@seadowg I checked on current Master and I wasn't able to reproduce this issue on Android 12 and 13, but then I checked the store version (2022.3.5) where the issue with removing points in GeoShape widget still exists and I could reproduce it in GeoShape on 12 and 13. @dbemke can You check once again in a free time on current master?

srujner avatar Oct 07 '22 10:10 srujner

on master 31897362c00974e7df889ef685337244f0ac5604 on Android 8.1, 10 the issue doesn't occur

dbemke avatar Oct 07 '22 14:10 dbemke

on master https://github.com/getodk/collect/commit/31897362c00974e7df889ef685337244f0ac5604

Ahh, great idea putting the commit hash. We should probably do that in addition to saying master so it continues being useful in the future.

Great to see that it's fixed. 👍

lognaturel avatar Oct 07 '22 16:10 lognaturel