collect icon indicating copy to clipboard operation
collect copied to clipboard

Double scroll bar when choice list is long

Open lognaturel opened this issue 2 years ago • 3 comments

When a choice list is long, there's a small scroll bar that shows the location in the list and there's also a big one that shows the location in the container view. There should only be the small scroll bar.

double scroll.zip

double-progress

lognaturel avatar Jul 01 '22 21:07 lognaturel

What if a form contains multiple questions on one screen? The we also shouldn't display both scrollbars? Screenshot_1657535112

grzesiek2010 avatar Jul 11 '22 10:07 grzesiek2010

What if a form contains multiple questions on one screen?

Ah, I knew it was going to be more complicated than I initially thought! Can you remind me what happens in that case? I can't really tell from the screenshot. The recyclerview takes up a fixed vertical space and then the rest of the field list goes below so depending on where you scroll you're either scrolling the choice list or the field list? To be honest, I'm not really sure what I expect scrollbar-wise in that case. As @seadowg likes to say, nested scrolling is 🤯. Do you have an expectation?

Could we perhaps leave this case alone and only deal with the more common case I filed? Now that I look at it again, I wonder whether maybe the underlying problem is that the recyclerview is too tall. What if we accounted for the top bar and the navigation bar in its height? That way there wouldn't have to be an outer scrollable view in the case of a single question per form.

This is not a big priority so if it's a lot of work we could certainly come back to it.

lognaturel avatar Jul 11 '22 22:07 lognaturel

Can you remind me what happens in that case? I can't really tell from the screenshot.

In that case we should have both scrollbars I think because there is one for the list of choices and another one for the whole list of questions.

The recyclerview takes up a fixed vertical space and then the rest of the field list goes below so depending on where you scroll you're either scrolling the choice list or the field list?

Theoretically yes but since the list of choices takes the whole available space horizontally and vertically it also extends the size of the screen it is difficult to scroll the list of questions without scrolling the list of choices. It's more of an indicator.

Now that I look at it again, I wonder whether maybe the underlying problem is that the recyclerview is too tall.

Its vertical size is 0.9 of screen height what probably always cause that together with toolbar, question label (assuming there is just one question) and navigation bar it takes more space than available and that's why we have that second scrollbar.

What if we accounted for the top bar and the navigation bar in its height? That way there wouldn't have to be an outer scrollable view in the case of a single question per form.

Yes probably we could try to calculate the height of the list in a better way so that it doesn't take more space than available. I will take a look at it.

grzesiek2010 avatar Jul 12 '22 14:07 grzesiek2010