collect icon indicating copy to clipboard operation
collect copied to clipboard

Backwards navigation and hierarchy view have different (and worse) rules about what they show compared to forward navigation

Open lognaturel opened this issue 3 years ago • 2 comments

Software and hardware versions

Collect v1.30.1, master

Problem description

Backwards navigation and hierarchy view have different (and worse) rules about what they show compared to forward navigation.

Steps to reproduce the problem

  1. Create a form with a repeat that could have no contents for some instances. E.g. vegetables.xlsx
  2. Fill out the form such that some instances are relevant and some are not. For example, select two vegetables in the attached form.
  3. Swipe forward to see the expected behavior.
  4. Swipe back to see a screen for each repeat instance, even those with no contents.
  5. Go to the hierarchy view from one of the "ghost" repeats to see more badness.

https://user-images.githubusercontent.com/967540/118725106-54ea4d80-b7e4-11eb-87c9-42315a3e4228.mp4

Expected behavior

If there are no visible notes in a repeat instance, that whole repeat instance should be skipped in all cases. The forward navigation behavior should be replicated.

Other information

Related to https://github.com/getodk/collect/issues/4457.

lognaturel avatar May 18 '21 21:05 lognaturel

This variation works as expected (other than #4570).

lognaturel avatar May 21 '21 04:05 lognaturel

Had a look at this but made little headway. XLSForm didn't like vegetables.xlsx at all to start with, then the repeats didn't work.

dimwight avatar Nov 28 '21 16:11 dimwight