Collect crashes when user minimizes app during deleting blank forms when Don't keep activity is turned on

[mmarciniak90]

Software and hardware versions

Collect v1.29 Beta 1, master Verified on Android 7.0, 8.1, 10.0

Problem description

Collect crashes when user minimizes app during deleting blank forms when Don't keep activity is turned on

Steps to reproduce the problem

1. Don't keep activities is turned on
2. User goes to Delete Saved Forms -> Blank Forms
3. User selects all forms
4. User clicks on Delete Selected -> dialog with progress bar displays
5. User minimizes an app
6. User goes back to Collect
7. Collect crashes crash.txt

Expected behavior

Dialog is restored

Other information

Related to #3843

@getodk-bot label "regression"

[lognaturel]

I put this in v1.29 so we don't forget about it but it's definitely not a must have.

[grzesiek2010]

I agree that this is not important and we can skip it for now. I created a pr https://github.com/getodk/collect/pull/4307 which doesn't solve this issue but at least avoid crashing. I think we should merge it without testing and work on better user experience (recreating the dialog) later.

[seadowg]

A note to myself here: I do wonder if we can find a way to get rid of executePendingTransactions as it feels really dodgy (pretty sure I added though). I'm sure at the time we did a bunch of work to see if there was a better way to make sure we don't end up with multiple dialogs, but I'd like to have another look at that.

[getodk-bot]

Hello @grzesiek2010, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @getodk-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!