central icon indicating copy to clipboard operation
central copied to clipboard

Published 20 hours ago • verified publisher icon getodk

"What's new" modal

Open lognaturel opened this issue 1 year ago • 1 comments

Figma file

  • Users who can edit forms in at least one project and had account prior to update
    • Should see the “What’s New” modal
    • User clicks on CTA, close button, or scrim to close
    • If a user closes the modal, there is currently (MVP) no way to revisit this content

lognaturel avatar Nov 26 '24 22:11 lognaturel

Possibly something about offline Entities.

Now that we're bumping this issue to .1, am I right in thinking that we probably won't mention offline entities anymore? So it'll just be about the "Edit Form" page?

matthew-white avatar Dec 08 '24 14:12 matthew-white

Looks like there is something wrong with "What's new" modal Image

srujner avatar May 05 '25 11:05 srujner

Looks like there is something wrong with "What's new" modal

Ah, that's my placeholder gradient image that we will soon update with a real image of the form draft change 😅

ktuite avatar May 05 '25 21:05 ktuite

@matthew-white Is this ready for testing? I see only modal that I posted above. I don't see the changes that are visible on the figma.

srujner avatar May 07 '25 06:05 srujner

Ok I found that it's waiting for the: https://github.com/getodk/central/issues/944 I think this PR should be tested after adding images in #944

srujner avatar May 07 '25 06:05 srujner

We are still working on #944, but I think it'd be OK to verify this issue now. We don't think it's likely that the image will interact with any of the other behavior, which is why we just put in a placeholder image for now. There are other, more complicated aspects of the issue, for example:

  • A user who can't see the Edit Form page in any project shouldn't see the What's New modal.
  • A user created today shouldn't see the What's New modal, but a user who was created before May should see it (as long as they can see the Edit Form page).
  • A user shouldn't see the modal more than once.

If you want to recheck the layout of the modal after #944, one option is that you could add the "needs testing" label to #944. Note that we probably won't finish #944 until the last minute: we can't take the screenshot to use for the image until we're done modifying the Edit Form page, which I'm still working on. It's partly for that reason that I think it makes sense to go ahead and verify the other aspects of this issue.

I don't see the changes that are visible on the figma.

Are there other expected things in Figma that aren't visible on the server?

matthew-white avatar May 08 '25 04:05 matthew-white

Tested with Success! @matthew-white I checked scenarios from you comment and did additional exploratory checks

srujner avatar May 08 '25 10:05 srujner