Mark pulling process as "Succeeded with some errors" instead of "Failed" if some form instances were skipped and the pulling process completed

[icemc]

Software versions

Briefcase v1.4.10, operating system Windows 8

Problem description

During pulling(of all types Aggregate, Collect directory etc) of form instances if one of the instances could not be downloaded then it is skipped and the pulling continues but at the end the whole process is marked as FAILED! even though the process completed and was not aborted. I think such events should be marked as "Succeeded with some errors"

Steps to reproduce the problem

Try pulling a form if an error occurs such that an instance is not downloaded the pulling process is marked as "FAILED" even though it completed

Expected behavior

if some form instances could not be downloaded during pull the pull process should be marked as "Succeeded with some errors" rather than "FAILED"

[icemc]

@yanokwa filed the issue as requested. Will send a PR soon

[yanokwa]

Closing because we can't reproduce it. Just in case someone comes across this issue, the best information have is from @icemc...

I came across this issue when I was downloading forms and my Internet connection wasn't the best. At some point I wasn't able to fetch some forms and I got a failed message. Initially I had an empty folder but at the end of the process I realized that briefcase was able to fetch some forms. This happened twince and I wasn't able to reproduce this issue intentionally."

[yanokwa]

Actually, one thing that might be good for a contributor to try is to see what happens if you pull forms and turn off the server or connection half-way through...

[yanokwa]

@icemc If you are looking for an issue to get back into the code, this one might be good to try to reproduce. Just comment @opendatakit-bot claim to claim it.