SocketIOClient-Unreal icon indicating copy to clipboard operation
SocketIOClient-Unreal copied to clipboard
verified publisher icon getnamo

fix ping/pong mechanism with practical debugging.

Open kybird opened this issue 2 years ago • 2 comments

if you unplug ethernet cable. current implementation can't detect it this fix will proper check it according to configuration of ping_timeout and ping_interval. anyway i am not sure what exactly original intention. this is just my implement by test with socket.io latest version. 4.6.1

kybird avatar Jul 17 '23 03:07 kybird

This is a bit risky change so I will schedule a proper testing round for it a bit later to test merge viability. Will need to ensure we don't get regression in expected behavior before merging.

getnamo avatar Sep 26 '23 19:09 getnamo

yes, it is.. i just concentrate on resolve the issue that is plug off the ethernet cable. current implementation can't recognize at least on my environment. base on testing environment and without understanding the base logic

kybird avatar Sep 27 '23 02:09 kybird