moto icon indicating copy to clipboard operation
moto copied to clipboard

Add instance variable annotations for SES models

Open giograno opened this issue 2 months ago • 1 comments

This PR reworks the annotation for SES, as suggested in https://github.com/getmoto/moto/issues/9389.

In a few instances, a proper type annotation would require the introduction of new types mapping specific AWS data types. A case would be having a type for dkim_attributes that implements the proper AWS type (DkimAttributes). Instead of introducing a new type, I left a generic typing.Any.

giograno avatar Oct 19 '25 07:10 giograno

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 93.00%. Comparing base (c75db89) to head (7edd158).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9387   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files        1294     1294           
  Lines      115774   115853   +79     
=======================================
+ Hits       107670   107750   +80     
+ Misses       8104     8103    -1     
Flag Coverage Δ
servertests 28.75% <88.57%> (+0.04%) :arrow_up:
unittests 92.98% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 19 '25 08:10 codecov[bot]