fix: prevent page reload on run trigger to open remote browser
Summary by CodeRabbit
-
New Features
- Added support for tracking robot run states in browser pool management.
- Enhanced workflow interpretation with improved event emissions.
- Implemented additional checks for active robot runs during browser recording sessions.
- Introduced job queue management for run workflows.
- Added local storage management for run information.
- Differentiated between scheduled and unscheduled runs in job processing.
- Integrated browser automation and external service interactions for workflow management.
-
Bug Fixes
- Improved handling of recording interpretation and run completion notifications.
-
Chores
- Refined socket connection and event handling mechanisms.
Walkthrough
The pull request introduces enhancements to browser management and workflow interpretation across multiple files. The changes focus on adding a new isRobotRun property to track robot run states in the BrowserPool, implementing a middleware to prevent multiple simultaneous robot runs, and improving event handling for run completions. The modifications aim to provide better control and monitoring of remote browser instances during automated workflows.
Changes
| File | Change Summary |
|---|---|
server/src/browser-management/classes/BrowserPool.ts |
- Added isRobotRun optional property to BrowserPoolInfo - Updated addRemoteBrowser method with new parameter - Added hasActiveRobotRun() and clearRobotRunState() methods |
server/src/browser-management/controller.ts |
- Modified addRemoteBrowser call to include isRobotRun parameter |
server/src/routes/record.ts |
- Added middleware to check for active robot runs - Prevent browser initialization if an active run exists |
server/src/workflow-management/classes/Interpreter.ts |
- Added 'run-completed' event emission after interpretation |
src/pages/MainPage.tsx |
- Removed conditional notifications in readyForRunHandler - Added useEffect for handling stored run information - Enhanced socket event handling |
server/src/routes/storage.ts |
- Added job to workflowQueue for run processing after run creation - Updated response structure to return browserId and runId |
server/src/worker.ts |
- Introduced new import alias for handleRunRecording - Modified job data structure to include isScheduled property |
server/src/workflow-management/record.ts |
- Added handleRunRecording function for managing browser automation and workflow execution |
Possibly related PRs
- getmaxun/maxun#386: The changes in the main PR are directly related to the modifications in the
addRemoteBrowsermethod and the introduction of theisRobotRunparameter, which are also present in the retrieved PR. - getmaxun/maxun#363: The changes in the main PR, which involve adding an
isRobotRunproperty and modifying theaddRemoteBrowsermethod, are related to the updates in the retrieved PR that include theisLoginproperty in theRobotmodel, as both involve modifications to the handling of boolean properties that affect the state of browser instances. - getmaxun/maxun#289: The changes in the main PR, specifically the updates to the
addRemoteBrowsermethod in theBrowserPoolclass, are directly related to the modifications made in thecreateRemoteBrowserForRunfunction in the retrieved PR, as both involve the addition of a new parameter to the same method.
Suggested reviewers
- amhsirak
Poem
🐇 In the realm of code where browsers play,
A new flag is set to guide the way.
Robot runs now in check,
With careful steps, we’ll not wreck.
Hopping through workflows, bright and spry,
Together we’ll reach for the sky! 🌟
[!TIP]
🌐 Web search-backed reviews and chat
- We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
- You can disable this feature by setting
web_search: falsein theknowledge_basesettings.- Please share any feedback in the Discord discussion.
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between e0773063ce527c4638cea9a9ccb6d31ff59a8516 and 8bb2ed357d58691fec0dc2a05655d721155d4380.
📒 Files selected for processing (1)
-
src/pages/MainPage.tsx(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/pages/MainPage.tsx
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai generate docstringsto generate docstrings for this PR. (Beta) -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@amhsirak Review