Mango icon indicating copy to clipboard operation
Mango copied to clipboard

[Feature Request] Sorting Nested Titles on The Title Page

Open somebelly opened this issue 4 years ago • 6 comments

Is your feature request related to a problem? Please describe. Now the sort options are only available in the first level. Please imagine that we have the folder structure below:

.
├── manga_jp
│   ├── manga_1.zip
│   └── manga_2.zip
├── manga_en
│   ├── manga_1
│   │   ├── 1st_series
│   │   │   ├── vol_1.cbz
│   │   │   ├── vol_2.cbz
│   │   │   └── vol_3.cbz
│   │   └── 2nd_series
│   │       ├── vol_1.cbz
│   │       └── vol_2.cbz
│   └── manga_2.zip
└── manga_cn
    ├── manga_1.zip
    ├── manga_2.zip
    └── manga_3.zip

We only have sort options for the 3 folders manga_jp, manga_en, manga_cn (which is kind of useless ...), and the subfolders are invariant when changing the sort option.

Describe the solution you'd like Just make the sort options available everywhere.

Describe a small use-case for this feature request See the folder structure mentioned above.

somebelly avatar Feb 19 '21 05:02 somebelly

I think this might actually be a bug since the sort options work fine in the last level as well, e.g. when there are only some .zip files in the folder. So maybe just for some reason, the sort options won't work in the "middle" level of the folder structure.

somebelly avatar Feb 19 '21 05:02 somebelly

Sorry, I am not sure I understand. Could you elaborate a bit on what you mean by "and the subfolders are invariant when changing the sort option"? Some screenshots might be helpful.

hkalexling avatar Feb 20 '21 05:02 hkalexling

https://user-images.githubusercontent.com/15066360/108601898-636cc880-739f-11eb-9c8d-5b2c414901c6.mp4

  • The sort options work only in . and the folders that ONLY have readable zip-like files.
  • If a folder is not . and has no zip-like files, it will not have a thumbnail.

somebelly avatar Feb 20 '21 16:02 somebelly

  • "manga_en" page (0:08): Sorting is not working here because you have only one title and one entry in it. Titles and entries are always displayed separately in two rows, and titles always appear before entries. So in this case there's nothing to sort.
  • "manga_1" page (0:16): Sorting is not working here because we didn't implement the sorting of nested titles. But I agree we should have this feature as the current state would confuse the users. Let me take a look when I have the time.
  • "manga_1" not having a thumbnail": Again this is a design choice and not a bug. We use the thumbnail of the first entry in a title as its thumbnail. When a title contains no entry, we just display the Mango logo.

hkalexling avatar Feb 22 '21 04:02 hkalexling

  • "Titles and entries are always displayed separately": maybe it's better to let the users choose if they prefer to display them separately since as shown in my example, we can have titles and entries that are different manga.
  • Thumbnail problem: in fact personally I don't understand why we treat folder and file differently.

The logic below seems better to me:

  • All of the folders and files of the same parent folder can be sorted equally and can have their own thumbnail.
  • If the user clicks a folder, then enter that folder.
  • If the user clicks a file, then open that file on the reader page.
  • A folder that has no subfolders can use the default Mango logo as its thumbnail if and only if:
    1. it's empty, or
    2. all files in this folder are unreadable.
  • A parent folder uses the same thumbnail as its first child (sorted alphabetically for example) that doesn't use the default Mango logo, which can be either a folder or a file.
  • A parent folder uses the default Mango logo if and only if all its children use the default Mango logo.

somebelly avatar Feb 22 '21 08:02 somebelly

Hi!

Sorting nested titles is implemented in #259

About a default thumbnail, you can change it here.

image

It's a manual manner, but I hope it would be helpful.

Leeingnyo avatar Dec 26 '21 04:12 Leeingnyo