lift icon indicating copy to clipboard operation
lift copied to clipboard

No allowance for quota increases

Open jonerickson opened this issue 3 years ago • 4 comments

In our particular case, we had an AWS Quota Limit increase on the number of Cloudfront forwarded headers from 10 to 15. At this time, it is hard coded to only allow 10 headers when projects can have more if approved by AWS.

jonerickson avatar Nov 23 '21 16:11 jonerickson

That's nice to know! I thought it was a hard limit.

I'll look into this and see how we can work with this and document it.

Thanks for your issue, it's truly appreciated 🙏

t-richard avatar Nov 23 '21 16:11 t-richard

Ohh interesting, thanks for sharing! Yeah, +1 on having that in the docs eventually.

mnapoli avatar Nov 23 '21 17:11 mnapoli

I've asked the AWS support for a quota increase which they gave me but I'm unable to use it for some reason.

I'm still in contact with the AWS support to figure this out...

But I looked at it even without the quota increase, I think we have two options

  1. remove the check, people will get a Cloudformation if they deploy more than 10 headers without asking for an increase
  2. keep the check and add an option to specify your maximum if you have an increase

2 provides a better DX for users as it fails fast and gives a clear message. 1 feels more natural and we would probably fail the same way if a user reached another quota.

LMKWYT

t-richard avatar Dec 03 '21 23:12 t-richard

I've thought about this as well. My initial thought was allowing a user to specify their max while keeping the check. The only thing for me is, it is not very cloud formationy and would be specific to the package. If you wanted to keep config values similar to Cloud Formation, then the option would be to remove the check and just let Cloud Formation fail when too many are specified.

jonerickson avatar Dec 04 '21 12:12 jonerickson