firetweet icon indicating copy to clipboard operation
firetweet copied to clipboard

Add a close button in the webView

Open sunshine19090 opened this issue 10 years ago • 7 comments

In the current build, the user cannot come out of the webView at any point of time. The user has to kill the app. It would be nice if the user has the option to close it. When closing, it should take the user back to FireTweet sign in screen

sunshine19090 avatar Apr 27 '15 18:04 sunshine19090

I'm able to hit the back button or tap outside the webview to close it. We could just add a close button. What might be even better is closing the webview after we reach the last registration-related page by detecting that URL, similar to https://stackoverflow.com/questions/18717045/closing-a-webview-on-url-detection

atavism avatar Apr 27 '15 21:04 atavism

OK, the latest version I uploaded automatically closes the webview and takes you back to the login screen whenever you reach the welcome screen/end of the registration process. I verified I'm able to create an account and login with it immediately afterwards.

atavism avatar Apr 28 '15 15:04 atavism

Am sorry about this. I am a iPhone user so am getting used to Android and totally forgot the use of back button. But I couldn't tap outside the webView to close it.

I will check your fix and let you know.

sunshine19090 avatar Apr 28 '15 16:04 sunshine19090

Unable to register as I get an error message during phone verification. Screenshot attached. screenshot_2015-04-29-00-18-02

sunshine19090 avatar Apr 28 '15 19:04 sunshine19090

Yeah, I believe that's a Twitter error: it's because that number is already associated with another account?

atavism avatar Apr 28 '15 19:04 atavism

I didn't use the phone number verification for any other account. That is the first time I used and I got this error.

I tried to reproduce but I am not getting the phone verification screen now(No idea why twitter would ask for phone verification). I am able to register via twitter and then it takes me to FireTweet. I still wanted to know how to check if it is going through proxy only.

sunshine19090 avatar Apr 29 '15 18:04 sunshine19090

The close button works fine in all the places except in the sign in screen where there is a link says "Sign up for Twitter". If I try to close, it just considers it as a click on that link and takes me to the register screen.

sunshine19090 avatar May 29 '15 18:05 sunshine19090