firetweet icon indicating copy to clipboard operation
firetweet copied to clipboard

Add social share menu

Open atavism opened this issue 10 years ago • 7 comments

Possibly with WeChat, Weibo, and Qzone buttons?

atavism avatar Jun 15 '15 22:06 atavism

I added a share button to the side menu as that seems like the best location for it:

image

When you click on this button, you have the option to share a link to download FireTweet to a bunch of different apps using the standard share intent (see Weibo and WeChat among the list which I have installed). I'm trying to figure out how to customize this list; it's unfortunate FireTweet itself appears. If we only want to allow sharing to certain apps, I think we have to create our own list view instead according to https://clickclickclack.wordpress.com/2012/01/03/intercepting-androids-action_send-intents/#

image

atavism avatar Jun 21 '15 18:06 atavism

Hey @Derekf5 and @myleshorton, what do you think about showing all the apps it's possible for the user to share to (above which is already implemented) vs. only being able to share to a predetermined set of apps (i.e. Weibo, WeChat, etc. for Chinese users)? The latter requires a custom solution, but it's doable.

atavism avatar Jun 25 '15 18:06 atavism

Also, @Derekf5, do we have specific text we want to use here? Probably something similar to the autotweet, but I think we want to also include the direct download link, right?

atavism avatar Jun 25 '15 18:06 atavism

I think the latter is a significant improvement actually @atavism.

On Thu, Jun 25, 2015 at 11:54 AM, atavism [email protected] wrote:

Also, @Derekf5 https://github.com/Derekf5, do we have specific text we want to use here? Probably something similar to the autotweet, but I think we want to also include the direct download link, right?

— Reply to this email directly or view it on GitHub https://github.com/getlantern/firetweet/issues/130#issuecomment-115361465 .

President Brave New Software Project, Inc. https://www.getlantern.org pgp A998 2B6E EF1C 373E 723F A813 045D A255 901A FD89

myleshorton avatar Jun 25 '15 18:06 myleshorton

@atavism text to go where? do you mean the text that users could share on various networks?

Derekf5 avatar Jun 25 '15 19:06 Derekf5

@Derekf5 Yeah, what do we want the share message to say?

atavism avatar Jun 25 '15 19:06 atavism

@atavism I think it can be pretty similar to the auto tweet.

"Check out FireTweet. A Twitter app for Android that allows for unblocked tweeting anywhere in the world! Link"

how does that sound? We will obviously need to translate that text.

Derekf5 avatar Jun 25 '15 19:06 Derekf5