kirby icon indicating copy to clipboard operation
kirby copied to clipboard

Add missing `reset` option for radio field

Open gitlabisbetterthangithub opened this issue 1 year ago • 4 comments

Should fix https://github.com/getkirby/getkirby.com/issues/2410

Description

This is my attempt at fixing https://github.com/getkirby/getkirby.com/issues/2410. This might not be correct as I might have misunderstood how the field properties table is generated. Hopefully it's correct.

You're right. But AFAIK we also need to unset the reset prop from select field since select field inherit from radio props.

afbora avatar Feb 14 '25 06:02 afbora

I am wondering about two things:

  • Should a radio button be resettable? The native HTML element isn't.
  • If it is resettable, should the default be true - I have doubts as this could be a larger breaking change for setups that have been build with them not been resettable.

distantnative avatar Feb 17 '25 21:02 distantnative

@distantnative I would agree with you here. We don't want them to be resettable in the first place in my opinion.

bastianallgeier avatar Feb 18 '25 07:02 bastianallgeier

@bastianallgeier That said, it's quite explicitly implemented in k-radio-input. Do we want to remove it? I'd think it would pose a breaking change.

distantnative avatar May 01 '25 17:05 distantnative

Closing in favor of https://github.com/getkirby/kirby/pull/7385

distantnative avatar Jul 15 '25 02:07 distantnative