kirby icon indicating copy to clipboard operation
kirby copied to clipboard

First steps code splitting with Vite 3

Open distantnative opened this issue 3 years ago • 3 comments

This PR …

Enhancements

  • Reduced size of the Panel's vendor JS file by adding code splitting for the vuedraggable.js library

Before

dist/css/style.css   106.29 KiB / gzip: 18.02 KiB
dist/js/index.js     303.70 KiB / gzip: 71.99 KiB
dist/js/vendor.js    375.31 KiB / gzip: 120.69 KiB

After

dist/js/vuedraggable.js   40.74 KiB / gzip: 14.12 KiB 
dist/css/style.css        106.29 KiB / gzip: 18.01 KiB
dist/js/index.js          304.26 KiB / gzip: 72.29 KiB
dist/js/vendor.js         333.99 KiB / gzip: 106.81 KiB

Ready?

  • [x] ~~Unit tests for fixed bug/feature~~
  • [x] ~~In-code documentation (wherever needed)~~
  • [x] Tests and checks all pass

For review team

distantnative avatar Jul 14 '22 09:07 distantnative

@afbora did my previous changes cause the problem you just fixed? and we probably should recompile list files then again.

distantnative avatar Aug 05 '22 08:08 distantnative

Yes, email mark was throwing error because of email mark has not the editor payload.

afbora avatar Aug 05 '22 08:08 afbora

Btw are we sure that want to move this changes to 3.7.3? I would favor of 3.7.4 since we already publish releases in short cycles.

afbora avatar Aug 05 '22 09:08 afbora