kirby
kirby copied to clipboard
Text input elements clip descenders on Chrome, Windows
Description
The tail of some descenders are clipped by the text inputs (all of them: text, email, etc.)
Expected behavior
Don't cut tail. Poor tail. Bad box!
Screenshots
Kirby 3.7
Kirby 3.6
To reproduce
- Buy a Windows machine and a 4k screen
- Open Edge or install and open Chrome
- Go to https://getkirby.com/try and click on "Start Demo"
- Click on "Open the panel"
- Insert
[email protected]
into the email box
Your setup
Kirby Version
3.7, but actually also prior versions.
Your system (please complete the following information)
- Device: Desktop PC
- OS: Windows 10/11
- Browser: Chrome, Edge
- Version: latest
Additional context
Firefox on the same machine, rendering the same font (Segoe UI) does not have this problem.
Chrome on Android does not have the problem (not rendering Segoe UI, though).
I have no idea why I didn't notice this before. Maybe because none of the names I normally write have descenders.
OH!
this also only seems to happen on 4k screens with Windows set to 150% magnification. At 100% or 200% it doesn't clip the text. I guess it's a subpixel rounding problem.
150% is the windows default for 4k screens though.
The input line height of 1.25rem doesn't seem sufficient for the font used in the panel. Two solutions I can think of: font or increasing line-height of inputs. I don't know if there is a more stable solution 🤷♂️
This issue has been automatically marked as stale because it has not had recent activity. This is for us to prioritize issues that are still relevant to our community. It will be closed if no further activity occurs within the next 14 days. If this issue is still relevant to you, please leave a comment.
![image](https://user-images.githubusercontent.com/6684137/216946569-97bb1e92-59d3-4af5-b1e6-b9ad90da9210.png)
@rasteiner can you also reproduce this in v4?
Seems to be ok in v4 👍
I will close this issue. For v3, there are more important issues to fix and with v4 it will then be fixed anyway. This is great. Thanks for testing again.