kin-openapi icon indicating copy to clipboard operation
kin-openapi copied to clipboard

WIP: Switch to gojsonschema

Open fenollp opened this issue 3 years ago • 4 comments

Fixes incorrect schema validation:

  • [ ] https://github.com/getkin/kin-openapi/issues/82
  • [x] https://github.com/getkin/kin-openapi/issues/171
  • [x] https://github.com/getkin/kin-openapi/issues/203
  • [x] https://github.com/getkin/kin-openapi/issues/267
  • [ ] https://github.com/getkin/kin-openapi/issues/280
  • [ ] https://github.com/getkin/kin-openapi/issues/293

Changes format support:

  • [ ] https://github.com/getkin/kin-openapi/issues/107

Also:

fenollp avatar Mar 03 '21 17:03 fenollp

What is holding this PR back? I really need kin-openapi to properly validate nullable enums. :(

bhechinger avatar Jul 06 '21 13:07 bhechinger

@bhechinger From #230 we most probably will move to use https://github.com/qri-io/jsonschema instead of the lib in this PR.

I didn't start work on this yet.. maybe give it a shot?

fenollp avatar Jul 06 '21 14:07 fenollp

@fenollp I'll take a look. If it's not going to be too much work to get done I may actually be able to make it a pre-req for my current task at work. :)

bhechinger avatar Jul 06 '21 15:07 bhechinger

Due to our current timeline crunch I won't have time for this right now. However, I was instructed to open a tech debt ticket to track this and come back to it later. If this hasn't been done by someone else in the next several months I will do it.

bhechinger avatar Jul 07 '21 11:07 bhechinger