Kyle Simpson comments

Results 631 comments of


                                            Kyle Simpson

Tests fail on cloned repository, even after running "npm install"

Yeah, that might work. Wouldn't be an npm script, so people would have to run it manually.

Comments on Documentation

In ASQ, the `then(..)` function assumes the following signature for its callbacks: ``` js ( triggerDoneCallback, msg1, msg2, ... ) ``` If you want it to behave like a `promise#then(..)`...

Comments on Documentation

this is great feedback on improving docs, appreciated. however, you've raised several substantial/important issues that need to be addressed. I would prefer you file these as separate issues so we...

Comments on Documentation

Thanks again, fantastic feedback. Will try to digest and make changes as I find some time. :)

Improve error when `signal` isn't passed down correctly to a sub-CAF

Thanks for the helpful suggestion. Will keep this in mind for the next update. :)

Cannot set property reason of #<AbortSignal> which has only a getter

When `AbortSignal` first came out, they had no `reason` or ability to set it with the `abort(..)` call. I considered that a huge failure of design so I added it...

Cannot set property reason of #<AbortSignal> which has only a getter

I've hopefully patched this bug with a successful fix (much more involved than I expected!!!). I did a pre-release on npm of CAF, at version `15.0.0-preA`. Can you install that...

Cannot set property reason of #<AbortSignal> which has only a getter

I will release a full 15.0.0 hopefully today. I wanted to validate that it fixed your concerns, but also to make sure the docs explain the necessary bits of this...

Cannot set property reason of #<AbortSignal> which has only a getter

So, I discovered there were still some issues with the `reason` behavior in various recent versions of Node (tested: 16.4.0, 16.11.1, 16.14.0, and 17.5.0). Annoyingly, `AbortSignal` landed the `reason` but...