You-Dont-Know-JS icon indicating copy to clipboard operation
You-Dont-Know-JS copied to clipboard

duplicate `.editorconfig` config, typo, sample code and grammar

Open dev-itsheng opened this issue 2 years ago • 3 comments

Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line).

Specifically quoting these guidelines regarding typos:

Typos?

Please don't worry about minor text typos. These will almost certainly be caught during the editing process.

If you're going to submit a PR for typo fixes, please be measured in doing so by collecting several small changes into a single PR (in separate commits). Or, just don't even worry about them for now, because we'll get to them later. I promise.


Please type "I already searched for this issue":

I already searched for this issue

Edition: (pull requests not accepted for previous editions) 2

Book Title:

Chapter: 1 & 2 & A & 4 & 5

Section Title: many

Topic:


I found an issue of sample code, but found that has been pointed in https://github.com/getify/You-Dont-Know-JS/pull/1770, so I didn't fix.

dev-itsheng avatar May 07 '22 18:05 dev-itsheng

👀

getify avatar May 07 '22 20:05 getify

The changes to the markup around "NOTE" elements is unnecessary.

getify avatar May 10 '22 13:05 getify

The changes to the markup around "NOTE" elements is unnecessary.

When I modified the text before, it triggered the editor's Markdown table formatting, which caused changes around NOTE:.

The amendments to that section have been withdrawn.

dev-itsheng avatar May 14 '22 03:05 dev-itsheng