JSON.minify icon indicating copy to clipboard operation
JSON.minify copied to clipboard

Published 20 hours ago • verified publisher icon getify

Port to LabVIEW

Open felipefoz opened this issue 3 years ago • 5 comments

Hey, I want to port this code to LabVIEW. I have already a working code and passing all tests in my machine. Following the instructions I believe I should open an issue before doing the fork, right? Waiting further instructions and possible discussion. Regards,

felipefoz avatar Jun 22 '21 01:06 felipefoz

Great! Can you follow these instructions? https://github.com/getify/JSON.minify/blob/master/PORTING.md

getify avatar Jun 22 '21 03:06 getify

Created pull request #62. Let me know if I did something wrong so I can rework it. Just by curiosity, do you know of any project like that for beautifier/prettier JSON?

felipefoz avatar Jun 22 '21 15:06 felipefoz

Hi, do you need any extra information to perform the pull request?

felipefoz avatar Aug 08 '21 08:08 felipefoz

I left it open because ideally I'd like to have any PR reviewed by someone who knows the language in question. Moreover, the nature of this language appears to be that you're not distributing a text source code that I (or anyone without LabVIEW) can actually look at. So it's hard for me to just accept the PR.

getify avatar Aug 08 '21 08:08 getify

Ok, I understand it. So, if someone volunteers to review the code, one can download the free IDE version from LabVIEW Community Edition.

felipefoz avatar Aug 08 '21 08:08 felipefoz