hyas icon indicating copy to clipboard operation
hyas copied to clipboard

Dev: move misplaced dependencies

Open AminZibayi opened this issue 3 years ago • 1 comments

Some dependencies are mistakenly placed in devDependencies section.

AminZibayi avatar Sep 12 '22 23:09 AminZibayi

Thanks, you're right indeed. Since I'm in the process of restructuring Hyas (see also https://github.com/h-enk/hyas/pull/329), I will hold your PR for now. So, I'll get back to you later /soon.

h-enk avatar Sep 14 '22 06:09 h-enk

The gethyas package is used by Hyas themes (e.g. Doks.) npm does not install devDependencies of a package it depends on. That's why all relevant gethyas dependencies are dependencies (and not devDependencies).

h-enk avatar Jun 19 '23 08:06 h-enk

And that's what I've done, I moved them from devDeps to deps, not vice versa.

AminZibayi avatar Jun 19 '23 17:06 AminZibayi

Yes, you're right! Sorry about that — I mixed up with another PR.

Thanks for your PR though!

h-enk avatar Jun 20 '23 06:06 h-enk