doks icon indicating copy to clipboard operation
doks copied to clipboard

fix: navbar-brand href now links to the BaseURL instead of `/`

Open CommanderStorm opened this issue 2 years ago • 0 comments

Summary

Currently, the navbar-brand links to "/". Given that BaseURL is configurabe, I think this is probably a bug.

Basic example

before:

<a class="navbar-brand order-0" href="/" aria-label="Foo">Foo</a>

after:

<a class="navbar-brand order-0" href="/foo" aria-label="Foo">Foo</a>

Motivation

In some instances, a URL like / is not possible. This is the case for example for websites like GitLab pages which serve under user.pages.instance.tld/projectname

Checks

  • [x] Read Create a Pull Request For some reason my IDE is not allowing me to edit commit messages, but this is probably not that big of an issue for this PR, as you can just edit the commit message via squashing this PR into main 😉
  • [x] Supports all screen sizes (if relevant)
  • [x] Supports both light and dark mode (if relevant)
  • [x] Passes npm run test

CommanderStorm avatar Sep 09 '22 20:09 CommanderStorm