doks icon indicating copy to clipboard operation
doks copied to clipboard

Image Shortcodes

Open CommanderStorm opened this issue 2 years ago • 1 comments

Description

I tried to add images with Subtiltles to our site. It turns out, that this feature has been dropped in a previous commit. This could be related to https://github.com/h-enk/doks/issues/133, but I don't think it is, so I decided to add another issue.

Steps to reproduce

  1. copy image shortcode from https://getdoks.org/docs/tutorial/add-images/

Expected result

Either no error, or this not being documented 😉

Actual result

image

Environment

Any commit after https://github.com/h-enk/doks/commit/24ad4ae339c9ebc76a2b35bde67555408eb2d706 is affected.

Proposed fix:

Revert the mentioned commit and removed everything relating to $lqip and lazySizes. I dont know why this fails though. Is this the reason you removed it?

CommanderStorm avatar Sep 06 '22 19:09 CommanderStorm

Thanks. It's just not documented yet (working on it). Doks now uses h-enk/hyas-images which uses danielfdickinson/image-handling-mod-hugo-dfd. For now, please check Daniel's repo.

I'll leave this issue open — as a reminder to update the documentation 😉

h-enk avatar Sep 07 '22 06:09 h-enk

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 08 '22 00:10 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Nov 09 '22 00:11 github-actions[bot]

You can now use the figure shortcode

h-enk avatar Jan 08 '24 14:01 h-enk