homepage icon indicating copy to clipboard operation
homepage copied to clipboard

Feature: add category icons

Open maharsh9100 opened this issue 3 years ago • 5 comments

Changes in this PR are as follows:

  • Add custom icons to the title/category header#215
  • Updates the services.yaml file
  • Export the resolveIcon function into Utils for reusability

Note: One of the commit message is "Update setting.yaml mapping" which is incorrect while the commit on is fine.

maharsh9100 avatar Sep 28 '22 20:09 maharsh9100

I'll work on resolving the conflicts.

maharsh9100 avatar Sep 28 '22 21:09 maharsh9100

I have resolved all the merge conflicts. Really great project!!! :smiley:

maharsh9100 avatar Sep 28 '22 21:09 maharsh9100

Thank you for the PR. I think some people may want this but this PR is a bit problematic imho as it alters the config schema i.e. it completely breaks an existing install's services...

At the very least it would need some kind of migration (not a good idea I think), otherwise I would consider a different way to do this, for example putting it in the layout map of the settings yaml or something like that. Even though the current way is 'cleaner', a complete breaking change just for this seems incongruous.

Also, code needs cleanup but I will hold off on that for now as the above is a 'show-stopper', again just IMHO.

shamoon avatar Oct 21 '22 05:10 shamoon

Have a look, I think its much simpler now to achieve this =)

settings.yaml:

layout:
  Home Management:
    icon: https://cdn-icons-png.flaticon.com/512/25/25694.png

Of course please let me know if you disagree

shamoon avatar Oct 22 '22 14:10 shamoon

Needs a squash, if merged.

shamoon avatar Nov 04 '22 04:11 shamoon

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

github-actions[bot] avatar Feb 06 '24 06:02 github-actions[bot]