hinode icon indicating copy to clipboard operation
hinode copied to clipboard

Image Enhancement: srcset dimensions, data-*

Open d-oit opened this issue 11 months ago • 3 comments

  • feat: data/dimensions.yml: implement auto with defined width dimensions
  • feat: image short code dataAttributes to create data-* e.g. <img data-attribute-Foo="foo">

d-oit avatar Dec 20 '24 18:12 d-oit

Deploy Preview for gethinode-demo ready!

Name Link
Latest commit a8a46e9ab1123b84983afb9d0a722144a8171eba
Latest deploy log https://app.netlify.com/sites/gethinode-demo/deploys/6765b60a88a8ad000843ee5a
Deploy Preview https://deploy-preview-1324--gethinode-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 88 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 20 '24 18:12 netlify[bot]

#1205 https://d-oit.github.io/en/blog/2024-11-13-enhanced-image-handling-on-d-oitgithubio/#key-changes

@markdumay Created this pr first without the lightbox js. Created a separate lightbox module with a gallery.html which needs these changes. Would you like the lightbox in Hinode or a module?

d-oit avatar Dec 20 '24 18:12 d-oit

when is this going to be merged to main?

actuallynotjohndoe avatar Jan 21 '25 15:01 actuallynotjohndoe