grav icon indicating copy to clipboard operation
grav copied to clipboard

No official Docker Hub images?

Open GoingOffRoading opened this issue 4 years ago • 7 comments

Seems like a pretty big gap for adoption

https://learn.getgrav.org/16/basics/installation

https://hub.docker.com/search?q=grav&type=image

GoingOffRoading avatar Aug 29 '20 22:08 GoingOffRoading

There is https://github.com/getgrav/docker-grav, but I guess it's not available on Docker Hub yet.

nbusseneau avatar Aug 30 '20 21:08 nbusseneau

Victory here would be not having to build the image and just being able to pull it down from Docker Hub

I.E. Being able to run "docker run -p 8000:80 grav:latest" without having to download the repo and building the image from the repo.

GoingOffRoading avatar Aug 30 '20 21:08 GoingOffRoading

As I am not a frequent docker user I’m not sure of the current state compares to other docker images in the hub. My guess is that it’s fine thigh and we just need to go through the official steps to get it listed.

Anyone have experience with this process?

rhukster avatar Aug 30 '20 22:08 rhukster

Anyone have experience with this process?

Not personally, however the process is laid out here: https://docs.docker.com/docker-hub/official_images/#creating-an-official-image

Basically entices submitting the Dockerfile in a PR to Docker Hub, and ensure it meets some standards defined here: https://github.com/docker-library/official-images/blob/master/NEW-IMAGE-CHECKLIST.md

And of course, maintaining it afterwards (usually via automated CI).

nbusseneau avatar Aug 30 '20 22:08 nbusseneau

@GoingOffRoading This is the closest I've found to your definition of victory: https://github.com/dsavell/docker-grav

It uses nginx and works a treat. I'm trying to build something very similar for Caddy. Don't think I'll bother with dockerhub though, you can pull images from anywhere.

hughbris avatar Sep 15 '20 05:09 hughbris

I'm kinda juggling multiple things at the moment, but as soon as I get a chance i'll be looking at this again.

rhukster avatar Sep 16 '20 16:09 rhukster

I created a Helm chart for running Grav in Kubernetes with Docker in case anyone is interested: https://github.com/tyzbit/helm-charts/tree/main/charts/grav. You can easily enable a sidecar container with filebrowser so you can directly edit the data in the directories. It uses https://hub.docker.com/r/dsavell/grav, which I suggest Grav ask to copy and use officially as it is a solid image.

I'd be happy to help set up builds on Docker Hub (and I suggest also pushing to GitHub's container registry since it would be almost no extra work. It requires more than just PRs as it'd be best to create an organization on Docker Hub to own the images.

Finally, as you can see here https://hub.docker.com/r/linuxserver/grav, LinuxServer has an unofficial grav image that is the top result when searching and the "SPONSORED OSS" on it makes it looks misleadingly official, but as users use these images they will ask for support here, wasting people's time. I suggest this issue be prioritized.

tyzbit avatar Aug 27 '23 02:08 tyzbit