grav-theme-learn2 icon indicating copy to clipboard operation
grav-theme-learn2 copied to clipboard

"Off" option for GitHub position is not showing up in Grav Admin

Open rbukovansky opened this issue 8 years ago • 9 comments

It seems to me that "off" option for GitHub position is not processed correctly by Grav Admin and not shown in combobox. Can you do anything about it or should I log issue with Grav Admin directly? Thanks.

screen shot 2017-02-09 at 15 22 14

rbukovansky avatar Feb 09 '17 14:02 rbukovansky

I see it fine in the latest release. Tested the RTFM skeleton 🤔

screen shot 2017-02-09 at 18 36 00

flaviocopes avatar Feb 09 '17 17:02 flaviocopes

Not for me... Took actual plain RTFM-skeleton from getgrav.org, no changes, except bin/gpm install admin, update to Learn2 installed via Admin and that option is still not there... :thinking:

Fedora 25 Server Apache 2.4.25 PHP 7.0.15

Grav v1.1.15 Admin v1.2.10 Learn2 v1.6.3

rbukovansky avatar Feb 10 '17 08:02 rbukovansky

The user/themes/learn2/blueprints.yaml file contains the "Off" option?

flaviocopes avatar Feb 10 '17 10:02 flaviocopes

Yup... screen shot 2017-02-10 at 11 04 53

rbukovansky avatar Feb 10 '17 10:02 rbukovansky

If you change "off" to something else, does it work? Anyone else can replicate the issue?

flaviocopes avatar Feb 10 '17 15:02 flaviocopes

Yes, those two other options work just fine.

rbukovansky avatar Feb 10 '17 15:02 rbukovansky

I mean, if you change off: Off to offtest: Offtest for example, does it work? To check if it's the specific string causing the problem

flaviocopes avatar Feb 10 '17 18:02 flaviocopes

Changing it to offtest: Offtest works. Reverting back to off: Off doesn't.

rbukovansky avatar Feb 13 '17 15:02 rbukovansky

I know I am a bit late, but @rbukovansky you can edit the yaml file in user/config/themes/learn2.yaml (make it if it doesn't exist) and add the following text:

top_level_version: false
home_url:
github:
    enabled: false
    position: off
    tree: https://github.com/getgrav/grav-skeleton-rtfm-site/blob/develop/
    commits: https://github.com/getgrav/grav-skeleton-rtfm-site/commits/develop/

Ensure that the text after position is off. There you go!

ghost avatar Nov 14 '17 03:11 ghost