grav-plugin-simplesearch icon indicating copy to clipboard operation
grav-plugin-simplesearch copied to clipboard

it seems the placeholder text is gone ?

Open JohnMica opened this issue 7 years ago • 12 comments

Hi guys,

Just updated to the latest version and it seems that the placeholder no longer finds the proper string to display. As per the picture attached it stays to the {.......placeholder} captura de ecran din 2017 06 02 la 00 44 27

is this just me messing around or maybe an error with the plugin ?

thanks in advance

JohnMica avatar Jun 01 '17 23:06 JohnMica

There for me: https://github.com/getgrav/grav-plugin-simplesearch/blob/develop/languages.yaml#L3

rhukster avatar Jun 01 '17 23:06 rhukster

i have the languages as well and they do look proper. still this strange glitch (cache disabled, local, mamp and codekit)

JohnMica avatar Jun 01 '17 23:06 JohnMica

Did you mess about with language files?

rhukster avatar Jun 01 '17 23:06 rhukster

I havent - i just checked them out to make sure that everything is there. I have updated the content of .searchbox.html.twig to the latest version and now i get an updated HTML input with the same placeholder issue ... captura de ecran din 2017 06 02 la 00 56 11

JohnMica avatar Jun 01 '17 23:06 JohnMica

https://demo.getgrav.org/blog-skeleton/

Seems ok here:

2017-06-01 at 5 59 pm

rhukster avatar Jun 01 '17 23:06 rhukster

i can see that = i'll replace my files completely and see if anything changes and i'll update this. thanks for the quick replies.

JohnMica avatar Jun 02 '17 00:06 JohnMica

I have played with the files and cant seem to make it work. AS per the picture attached, the rezults do get the proper translation from the array but not the placeholder.

captura de ecran din 2017 06 02 la 01 04 56

since I cant figure it out, I have hardcoded the placeholder for now,

JohnMica avatar Jun 02 '17 00:06 JohnMica

@JohnMica you have translations enabled in the System configuration?

flaviocopes avatar Jun 02 '17 15:06 flaviocopes

@FlavioCopes - translations are enabled and default language is Romanian. As you can see the results.html.twig picks up the translation just the placeholder doesn't really want to ... not sure why

JohnMica avatar Jun 02 '17 15:06 JohnMica

Do you have system.languages.translations_fallback enabled? I notice the string is not translated in romanian, so maybe it's not picked up for this reason. Otherwise, adding it to the ro translations should work

flaviocopes avatar Jun 05 '17 13:06 flaviocopes

Hey guys! I had the same issue, fixed it by switching languages: translations: false to translations: true. What make sense because in other way translations are not working.

mxnr avatar Jun 21 '17 00:06 mxnr

Seems that none of the placeholders get fillled. German translation is activated and the german strings look correct to me. snapshot1

eisenherzz avatar Oct 14 '17 06:10 eisenherzz