grav-plugin-form icon indicating copy to clipboard operation
grav-plugin-form copied to clipboard
verified publisher icon getgrav

Remove security and privacy issue Gravatar #544

Open Rotzbua opened this issue 4 years ago • 3 comments

Fixes: Remove security and privacy issue Gravatar #544

Change: Replaces Gravatar image with an user icon.

Rotzbua avatar Dec 27 '21 16:12 Rotzbua

This changes the existing behavior. If your would like this functionality it should be an optional setting via the admin plugin.

rhukster avatar Dec 27 '21 17:12 rhukster

Then the functionality should not be hardcoded in the form plugin.

The functionality should just be coded in one place. Currently I found it in 3 places: core, admin and forms...

Rotzbua avatar Dec 27 '21 17:12 Rotzbua

@rhukster I reviewed my PR. So far this PR does not change a functionality. The reason is, that function getAvatarUrl() from core always returns an url with gravatar as default. So avatar is always true and the else part is never executed. If my open PR https://github.com/getgrav/grav/pull/3501 on core is merged this PR would have an impact.

Rotzbua avatar Jan 06 '22 15:01 Rotzbua