grav-plugin-admin icon indicating copy to clipboard operation
grav-plugin-admin copied to clipboard
verified publisher icon getgrav

Event 'onAdminRegisterPermissions' replaced with oddly named 'PermissionsRegisterEvent::class' event

Open pamtbaau opened this issue 3 years ago • 0 comments

Just curious, why has an oddly event name PermissionsRegisterEvent::class been chosen when deprecating event onAdminRegisterPermissions?

It feels as if code for Grav v1.7.0-rc.4 and Admin v1.10.0-rc.4 hasn't been properly finished...

Wouldn't a name like onAdminPermissionsInitialized be more in line with longstanding event names like:

  • onProblemsInitialized
  • onPluginsInitialized
  • onThemeInitialized
  • onBackupsInitialized
  • onSchedulerInitialized
  • onAssetsInitialized
  • onTwigInitialized
  • onBuildPagesInitialized
  • onPagesInitialized
  • onPageInitialized
  • onMarkdownInitialized

Would it be possible to replace event name PermissionsRegisterEvent::class with a better one?

pamtbaau avatar Aug 04 '22 04:08 pamtbaau