nft-contracts icon indicating copy to clipboard operation
nft-contracts copied to clipboard

Souldbound Burn

Open TheSmartnik opened this issue 2 years ago • 0 comments

Hi, I have a couple of question regarding souldbound contract.

First.

https://github.com/getgems-io/nft-contracts/blob/debcd8516b91320fa9b23bff6636002d639e3f26/packages/contracts/sources/sbt-item.fc#L164

Why the flag here isn't 128 + 32. Considering that we want to burn the contract, it seems like a more appropriate solution.

Second.

https://github.com/getgems-io/nft-contracts/blob/debcd8516b91320fa9b23bff6636002d639e3f26/packages/contracts/sources/sbt-item.fc#L166-L168

Even if for some reason 128 is appropriate flag. Why not set collection address to null() as well. That way It'll auto detach from collection in every parsing tool

TheSmartnik avatar Dec 27 '22 11:12 TheSmartnik