dokan icon indicating copy to clipboard operation
dokan copied to clipboard

Enhance: Update dokan admin dashboard logo & add logo update notice.

Open MdAsifHossainNadim opened this issue 10 months ago • 8 comments

Enhance: Update dokan admin logo & add logo update notice.

All Submissions:

  • [x] My code follow the WordPress' coding standards
  • [x] My code satisfies feature requirements
  • [x] My code is tested
  • [x] My code passes the PHPCS tests
  • [x] My code has proper inline documentation
  • [x] I've included related pull request(s) (optional)
  • [x] I've included developer documentation (optional)
  • [x] I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

  • Full PR Link

Closes

How to test the changes in this Pull Request:

  • Go to dokan admin dashboard & see menu logo, admin settings logo, admin logo notice etc.

Changelog entry

Fix: Update dokan admin dashboard logo & add logo update notice.

Detailed Description of the pull request. What was previous behaviour and what will be changed in this PR.

Before Changes

image

After Changes

Screenshot 2024-04-26 at 4 25 58 PM

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • [ ] Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • [ ] Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • [ ] Readable — Will your future self be able to understand this change months down the road?
  • [ ] Elegant — Does the change fit aesthetically within the overall style and architecture?

MdAsifHossainNadim avatar Apr 26 '24 10:04 MdAsifHossainNadim

@shohag121 Vhaiya, kindly review this PR at your convenience.

MdAsifHossainNadim avatar Apr 26 '24 10:04 MdAsifHossainNadim

Scenario: The icon needs to update on several places on dokan

Screenshot at Apr 29 17-04-31 Screenshot at Apr 29 17-05-50 Screenshot at Apr 29 17-08-28 Screenshot at Apr 29 17-08-49

shashwatahalder01 avatar May 02 '24 04:05 shashwatahalder01

@mrabbani Vhai, need to relevant ui's for new issues. @shashwatahalder01 Vhai, If anything is required or if you have any suggestions for us, then feel free to inform us.

MdAsifHossainNadim avatar May 02 '24 07:05 MdAsifHossainNadim

@MdAsifHossainNadim, @mrabbani, It would be better if we could introduce a new color pallet that is aligned with the latest dokan logo

image

shashwatahalder01 avatar May 02 '24 07:05 shashwatahalder01

Here is the Design Link. Please have a look.

tuhin480 avatar May 07 '24 05:05 tuhin480

@tuhin480 Vhai, we need to make consistent between existing banner & updated logo. Here is the preview after updating logo.

Screenshot 2024-05-08 at 9 27 54 AM Screenshot 2024-05-08 at 9 27 07 AM

I think It will be better if we added some shadow or spaces on left/bottom side in this banner image. (as like as previous)

image

Screenshot 2024-05-08 at 9 55 21 AM

We need to update wp org's banner & icon logo's as per latest update.

image (35)

CC: @mrabbani @ashrafux

MdAsifHossainNadim avatar May 16 '24 03:05 MdAsifHossainNadim

This issue was split into two different GitHub links, which caused a delay. I've completed all the tasks and would like to request you to review the design. Design Link Cc: @ashrafux @mrabbani @Mohaiminulislam1989

tuhin480 avatar Aug 28 '24 06:08 tuhin480

This issue was split into two different GitHub links, which caused a delay. I've completed all the tasks and would like to request you to review the design. Design Link Cc: @ashrafux @mrabbani @Mohaiminulislam1989

@imtiaz-pranto via, Pls review design and let us know your feedback.

mrabbani avatar Aug 28 '24 09:08 mrabbani